Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility test more pages with Axe #1408

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

gabalafou
Copy link
Collaborator

@gabalafou gabalafou commented Aug 14, 2023

Closes #1378.

There are some open questions on #1378 that need to be answered before I can be sure if this PR closes that issue.

@trallard trallard self-requested a review August 14, 2023 13:39
@trallard trallard added the tag: accessibility Issues related to accessibility issues or efforts label Aug 14, 2023
Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gabalafou this looks good to me so I would be glad to merge.
I know you want to review some of the comments in the original issue so will wait a couple of days before merging just in case

@trallard
Copy link
Collaborator

Since all the comments in the original issue are now resolved will merge 🚀 thank you @gabalafou

@trallard trallard merged commit ae7af87 into pydata:main Aug 18, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: accessibility Issues related to accessibility issues or efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT: Broaden coverage of accessibility tests with Playwright
2 participants