Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill the docs-live infinite loop (yet again) #1540

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

drammock
Copy link
Collaborator

this avoids the nox -s docs-live infinite loop (which has resurfaced again) by

  1. ignoring the _build folder (why it is among the watched files list to begin with baffles me; cf. Use a time window to detect changes in batches sphinx-doc/sphinx-autobuild#124 (comment))
  2. making the notebook use a random seed so that its generated images don't change on each rebuild
  3. bumping the version of sphinx-theme-builder so that the re_ignore CLI option actually works (i'd been running off my PR branch, nowadays the PR is merged)

@drammock drammock added the kind: maintenance Improving maintainability and reducing technical debt label Oct 25, 2023
pyproject.toml Show resolved Hide resolved
docs/examples/pydata.ipynb Show resolved Hide resolved
@gabalafou
Copy link
Collaborator

Oh sweet. I was about to go digging into this myself, since I've been doing a lot of fine-grained, iterative CSS work and I was getting tired of the following dev loop: make change, stop server, rebuild, wait for build to finish, restart server.

@drammock drammock merged commit e86e0ab into pydata:main Oct 26, 2023
19 checks passed
@drammock drammock deleted the make-notebook-non-random branch October 26, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: maintenance Improving maintainability and reducing technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants