Raise exception for response codes outside range 200-299 #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammock
approved these changes
Apr 9, 2024
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/sections/announcement.html
Outdated
Show resolved
Hide resolved
…ouncement.html Co-authored-by: Daniel McCloy <[email protected]>
|
I'm joining the conversation late, but this was approved and seem reasonable, i'm going to take some risks and merge. |
gabalafou
added a commit
to gabalafou/pydata-sphinx-theme
that referenced
this pull request
May 21, 2024
Carreau
added a commit
that referenced
this pull request
May 23, 2024
The banner animation felt a little funky to me, even after the improvements made in #1693. My hunch is that because the two banners are stacked on top of each other and the height of one affects the layout/position of the other, trying to animate the height of both of them at the same time causes the browser to stutter. Or maybe it was just because they could each load at different but often only slightly offset times. Whatever the case, I decided to do a little code clean up and change it so that they both come in together. In the process of working on this PR it also made sense to address a TODO, and add "Version warning" to the list of translatable strings. * pybabel extract . -F babel.cfg -o src/pydata_sphinx_theme/locale/sphinx.pot -k '_ __ l_ lazy_gettext' * pybabel update -i src/pydata_sphinx_theme/locale/sphinx.pot -d src/pydata_sphinx_theme/locale -D sphinx * Update src/pydata_sphinx_theme/theme/pydata_sphinx_theme/sections/announcement.html * incorporate #1755 --------- Co-authored-by: M Bussonnier <[email protected]>
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
GitHub pages return valid HTML page when an element was removed. This adds a check for return code to not inject returned HTML if the return code is outside range 200-299. Co-authored-by: Daniel McCloy <[email protected]>
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
The banner animation felt a little funky to me, even after the improvements made in pydata#1693. My hunch is that because the two banners are stacked on top of each other and the height of one affects the layout/position of the other, trying to animate the height of both of them at the same time causes the browser to stutter. Or maybe it was just because they could each load at different but often only slightly offset times. Whatever the case, I decided to do a little code clean up and change it so that they both come in together. In the process of working on this PR it also made sense to address a TODO, and add "Version warning" to the list of translatable strings. * pybabel extract . -F babel.cfg -o src/pydata_sphinx_theme/locale/sphinx.pot -k '_ __ l_ lazy_gettext' * pybabel update -i src/pydata_sphinx_theme/locale/sphinx.pot -d src/pydata_sphinx_theme/locale -D sphinx * Update src/pydata_sphinx_theme/theme/pydata_sphinx_theme/sections/announcement.html * incorporate pydata#1755 --------- Co-authored-by: M Bussonnier <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub pages return valid HTML page when an element was removed.
This PR add check for return code to not inject returned HTML if the return code is outside range 200-299.