Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the latest minor version of fontawesome 6 #1768

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Conversation

12rambau
Copy link
Collaborator

Fix #1767

I changed the devcontainer so NodeJS commands are now available for codespace users and changed the version spec of fontawesome in package.json.

I copy/pasted the icon from the issue for testing I'll copy/paste a screenshot and remove it from the code afterward.

@12rambau
Copy link
Collaborator Author

image

@12rambau 12rambau marked this pull request as ready for review April 12, 2024 15:00
@drammock drammock merged commit 9ade2e8 into pydata:main Apr 12, 2024
19 checks passed
@12rambau 12rambau deleted the font branch April 12, 2024 15:13
gabalafou pushed a commit to gabalafou/pydata-sphinx-theme that referenced this pull request Apr 29, 2024
* fix: use the latest minor version of fontawesome 6

* update dependencies

* remove bluesky icon
ivanov pushed a commit to ivanov/pydata-sphinx-theme that referenced this pull request Jun 5, 2024
* fix: use the latest minor version of fontawesome 6

* update dependencies

* remove bluesky icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fontawesome 6 icons do not work
2 participants