tiny CSS change #1769
Merged
tiny CSS change #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammock
added
the
kind: maintenance
choldgraf
approved these changes
Apr 14, 2024
There was a problem hiding this comment.
Seems reasonable to me as long as it doesn't have unintended side effects (eg maybe double check the notebook outputs to make sure they're ok still). But my understanding is that background-color is better to use anyway if you're just specifying color because it is more precise.
12rambau
approved these changes
Apr 14, 2024
Carreau
approved these changes
Apr 15, 2024
gabalafou
pushed a commit
to gabalafou/pydata-sphinx-theme
that referenced
this pull request
Apr 29, 2024
background → background-color
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
background → background-color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
backgroundproperties tobackground-color. This should make no difference to the rendered site (when only color is given, the two properties yield identical results). But for some reason, in the Firefox developer tools, specifying asbackground-colormakes it show up in the "computed styles" list when filtering on either "background" or "color" (as you would expect), but when specified as justbackgroundthe property doesn't show up for either search term.Arguably this is a bug in the FF dev tools, but this workaround is fast and painless so why not?