Fix focus ring glitch on API autosummary "[source]" link #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabalafou
commented
Apr 19, 2024
| @@ -111,6 +111,21 @@ span.highlighted { | |||
| background-color: var(--pst-color-target); | |||
| } | |||
|
|
|||
| dl > dt > a:has(.viewcode-link) { | |||
There was a problem hiding this comment.
If you know a way to improve the safety of this selector, please let me know!
9 tasks
Carreau
approved these changes
Apr 23, 2024
gabalafou
added
the
tag: accessibility
gabalafou
added a commit
to gabalafou/pydata-sphinx-theme
that referenced
this pull request
Apr 29, 2024
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See code comments for motivation and explanation.
Before
The following screenshot shows how the focus ring bug looks in Chrome:
After
The following screenshot shows the focus ring fixed in Chrome: