Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zeros_like should accept order= parameter #514

Closed
crusaderky opened this issue Aug 26, 2021 · 0 comments
Closed

zeros_like should accept order= parameter #514

crusaderky opened this issue Aug 26, 2021 · 0 comments
Labels
enhancement Indicates new feature requests

Comments

@crusaderky
Copy link
Contributor

sparse.zeros_like, ones_like, full_like should accept the order= parameter, for the sake of compatibility with NEP18-compatible wrappers, such as dask - see use case in pydata/xarray#5654.
I'm unsure if order= makes sense or not for sparse, but if it doesn't it should be accepted nonetheless and silently ignored.
@crusaderky crusaderky added the enhancement Indicates new feature requests label Aug 26, 2021
@crusaderky crusaderky mentioned this issue Aug 26, 2021
Merged
hameerabbasi added a commit to hameerabbasi/sparse that referenced this issue Aug 28, 2021
@hameerabbasi
Add order parameter to {zero, ones, fukk}[_like].
1c93fb1 
Fixes pydata#514.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crusaderky