List "Unindexed dimensions" separately in __repr__ #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GH1199
Previously (on master):
<xarray.Dataset>
Dimensions: (x: 1, y: 2)
Coordinates:
o x (x) -
o y (y) -
Data variables:
foo (x, y) int64 1 2
Now:
<xarray.Dataset>
Dimensions: (x: 1, y: 2)
Coordinates:
*empty*
Unindexed dimensions:
x, y
Data variables:
foo (x, y) int64 1 2
This version of the `__repr__` should be much more self-explanatory.
shoyer
commented
Jan 20, 2017
| @@ -685,6 +686,23 @@ def test_coords_merge_mismatched_shape(self): | |||
| actual = orig_coords.merge(other_coords) | |||
| self.assertDatasetIdentical(expected, actual) | |||
|
|
|||
| def test_data_vars_properties(self): | |||
There was a problem hiding this comment.
It looks like we were missing tests for data_vars previously, which I noticed when I renamed the formatting function and an error appeared in the docs build. Oops!
fmaussion
approved these changes
Jan 20, 2017
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff(except for lines which need to be long for displaying a repr)Previously (on master):
Now:
This version of the
__repr__should be much more self-explanatory.