Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace task_state with tasks in dask test #1904

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

mrocklin
Copy link
Contributor

@mrocklin mrocklin commented Feb 12, 2018

This internal state was changed in the latest release

  • Closes Broken distributed test #1903 (remove if there is no corresponding issue, which should only be the case for minor changes)
  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)
  • Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

This internal state was changed in the latest release

Fixes pydata#1903
@fmaussion
Copy link
Member

fmaussion commented Feb 12, 2018

Thanks @mrocklin ! Could you change the version number checking in the test decorator as well? (@pytest.mark.skipif(distributed.__version__ <= '1.19.3' should become <1.20.2)

@mrocklin
Copy link
Contributor Author

Why this version number in particular?

@mrocklin
Copy link
Contributor Author

I believe that this change will be valid across a number of versions, including the most recent.

@fmaussion
Copy link
Member

Why this version number in particular?

Sorry, I thought the namespace change happened in v1.20.2 . If the tasks attribute was available in earlier versions of distributed we can keep the decorator as it is.

@fmaussion fmaussion merged commit ee38ff0 into pydata:master Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken distributed test
3 participants