Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: refresh "Why xarray" and shorten top-level description #2657

Merged
merged 4 commits into from
Jan 11, 2019

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented Jan 7, 2019

This documentation revamp builds upon @rabernat's rewrite in #2430.

The main change is that the three paragraph description felt too long to me, so I moved the background paragraph on multi-dimensional arrays into the next section, on "Why xarray". I also ended up rewriting most of that page, and made a few adjustments to the FAQ and related projects pages.

This documentation revamp builds upon rabernat's rewrite in GH2430.

The main change is that the three paragraph description felt too long to me, so
I moved the background paragraph on multi-dimensional arrays into the next
section, on "Why xarray". I also ended up rewriting most of that page, and
made a few adjustments to the FAQ and related projects pages.
Copy link
Contributor

@rabernat rabernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good to me!

doc/faq.rst Outdated
dimensional data structures.

Pandas gets a lot of things right, but scientific users (and many others) need
fully multi-dimensional data structures.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a good place to explicitly mention deep learning libraries?

README.rst Show resolved Hide resolved
they have labels which encode information about how the array values map
to locations in space, time, etc.

Xarray doesn't just keep track of labels on arrays: it uses them to provide a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use a dash instead of a colon

@dcherian
Copy link
Contributor

LGTM but I'll hold off on clicking merge. Apologies for merging too quickly the last time around.

@shoyer shoyer merged commit d4c4682 into pydata:master Jan 11, 2019
dcherian pushed a commit to dcherian/xarray that referenced this pull request Jan 14, 2019
* upstream/master:
  xfail cftimeindex multiindex test (pydata#2669)
  DOC: refresh "Why xarray" and shorten top-level description (pydata#2657)
  Remove broken Travis-CI builds (pydata#2661)
  Type checking with mypy (pydata#2655)
  Added Coarsen (pydata#2612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants