Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix: use == to compare strings #2832

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Conversation

max-sixty
Copy link
Collaborator

is relies on interning, which is almost always OK for small strings, but reliant on language implementations

(unless there's something I'm missing about .kind?)

@shoyer shoyer merged commit 8126d3e into pydata:master Mar 22, 2019
@shoyer
Copy link
Member

shoyer commented Mar 22, 2019

thanks, this is definitely the right thing to do

@max-sixty max-sixty deleted the is_equals branch March 22, 2019 02:40
@max-sixty
Copy link
Collaborator Author

I picked this and #2833 up b/c I have flake8 checking in my editor.

I think we moved to restricting our automated checks to pycodestyle #2642 rather than the fuller flake8. I'm generally keen on more automated checks and less reliance on humans, but defer to @shoyer as ever

@shoyer
Copy link
Member

shoyer commented Mar 23, 2019

I think pep8speaks supports flake8 checks now, so that is a viable option. Previously it only did pycodestyle, and I didn't want to force people to read the build logs to get lint errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants