Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure explicitly indexed arrays are preserved #3027

Merged
merged 4 commits into from
Jun 23, 2019

Commits on Jun 17, 2019

  1. Ensure indexing explicitly indexed arrays don't leak out.

    Previously, indexing an ImplicitToExplicitIndexingAdapter object could directly
    return an ExplicitlyIndexed object, which could not be indexed normally. This
    resulted in broken behavior with dask's new `_meta` attribute.
    
    This change almost but not entirely fixes xarray on dask master. There are
    still errors raised inside two tests from dask's `blockwise_meta` helper
    function:
    
    >       return meta.astype(dtype)
    E       AttributeError: 'ImplicitToExplicitIndexingAdapter' object has no attribute 'astype'
    shoyer committed Jun 17, 2019
    Configuration menu
    Copy the full SHA
    fa76ab7 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2019

  1. Configuration menu
    Copy the full SHA
    f865f8e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bc9786d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6da02d3 View commit details
    Browse the repository at this point in the history