chunk sparse arrays #3202
Merged
chunk sparse arrays #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
reviewed
Aug 11, 2019
shoyer
reviewed
Aug 11, 2019
crusaderky
commented
Aug 12, 2019
| ac = a.chunk(2) | ||
| assert ac.chunks == ((2, 2),) | ||
| assert isinstance(ac.data._meta, sparse.COO) | ||
| assert_identical(ac, a) |
There was a problem hiding this comment.
I'm guessing this is due to dask/dask#5259
|
Ready for final review and merge |
shoyer
approved these changes
Aug 12, 2019
|
@shoyer NEP18 and type annotations feel like two groundbreaking changes to me. Shall we call the next version to 0.13.0 instead of just 0.12.4? |
Sounds pretty reasonable to me! |
|
I don't think we're quite ready to release 0.13 today -- NEP-18 support could probably use a bit more polish. But we're pretty close. |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Aug 14, 2019
* upstream/master: chunk sparse arrays (pydata#3202) Annotations for .data_vars() and .coords() (pydata#3207) Remove duck_array_ops.as_like_arrays() (pydata#3204) Match mypy version between CI and pre-commit hook (pydata#3203) BUG fix +test .sel method gives error with float32 values (pydata#3153) fix precommit file (pydata#3201) Enforce mypy compliance in CI (pydata#3197)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3191
@shoyer I completely disabled wrapping in ImplicitToExplicitIndexingAdapter for sparse arrays, cupy arrays, etc.
I'm not sure if it's desirable; the chief problem is that I don't think I understand the purpose of ImplicitToExplicitIndexingAdapter to begin with... some enlightenment would be appreciated.