-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add head, tail and thin methods #3278
Conversation
Hello @DangoMelon! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-09-04 19:28:37 UTC |
Looks great! V good first effort @DangoMelon Any thoughts from others? Do we want a default (e.g. 5)? |
Do we want to support integer values, indicating that an operation should be applied to all dimensions? e.g., supposing This would be a natural way to support a default value (if we want that) -- we could simply set the default value to 5, so |
But yes, I agree with @max-sixty this looks great, and already ready to merge! If you don't have time to work on default values and/or integers now, we can always merge this PR now and leave those backwards compatible API changes for later :) |
Great! In the spirit of faster iteration, I'll merge this @DangoMelon and then if you want to add default values (I also like the idea of supporting a single value), please go ahead! |
Thanks @max-sixty @shoyer !! I also agree with your suggestions and will be working on adding the default values during these days. |
* master: Fix whats-new date :/ Revert to dev version Release v0.13.0 auto_combine deprecation to 0.14 (pydata#3314) Deprecation: groupby, resample default dim. (pydata#3313) Raise error if cmap is list of colors (pydata#3310) Refactor concat to use merge for non-concatenated variables (pydata#3239) Honor `keep_attrs` in DataArray.quantile (pydata#3305) Fix DataArray api doc (pydata#3309) Accept int value in head, thin and tail (pydata#3298) ignore h5py 2.10.0 warnings and fix invalid_netcdf warning test. (pydata#3301) Update why-xarray.rst with clearer expression (pydata#3307) Compat and encoding deprecation to 0.14 (pydata#3294) Remove deprecated concat kwargs. (pydata#3288) allow np-array levels and colors in 2D plots (pydata#3295) Remove some deprecations (pydata#3292) Make argmin/max work lazy with dask (pydata#3244) Add head, tail and thin methods (pydata#3278) Updater to testing environment name (pydata#3253)
I feel like there's room for improvement in the docstrings, any change or suggestion is welcome!
black . && mypy . && flake8
whats-new.rst
for all changes andapi.rst
for new API