Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add glossary to documentation #3352
Add glossary to documentation #3352
Changes from 3 commits
b492a21
1c40460
3bf9fa7
71ffb19
7363c5a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about
A *dimension* is a nonnegative number for the dimensionality
—I think that's a good definition for dimensionality, but wouldn't think of a dimension as a number?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I struggled with this because in math, a "dimension" is a number, but in common parlance and xarray, "dimension" is often used to refer to a dimension axis—or a locus in which all but one of the coordinates ("coordinates" in the math sense, not xarray sense) is fixed. I didn't want to define "coordinate" and "dimension" in the math sense and then re-define them, although I think that would be the clearest at the expense of brevity.
Anyway, how about this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth borrowing the description from the netCDF data model documentation: https://www.unidata.ucar.edu/software/netcdf/docs/netcdf_data_model.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-dimensional coordinates can be multi-dimensional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought "multi-dimensional coordinates" really just meant multiple one-dimensional coordinate arrays labeling the same dimension. I inferred that from this page. Is this what you mean or something else? Also, could you please show me an example? I've tried and failed to use
assign_coords
to add a multi-dimensionalDataArray
as a coordinate array.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example