Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH5005 fix documentation on open_rasterio #5021

Merged
merged 7 commits into from
Mar 15, 2021

Conversation

gabriel-abrahao
Copy link
Contributor

@gabriel-abrahao gabriel-abrahao commented Mar 10, 2021

@keewis
Copy link
Collaborator

keewis commented Mar 14, 2021

@gabriel-abrahao, do you want to try converting the code block to doctest? Otherwise this looks good to me and should be ready for merging.

@gabriel-abrahao
Copy link
Contributor Author

@gabriel-abrahao, do you want to try converting the code block to doctest? Otherwise this looks good to me and should be ready for merging.

I tried, but building the documentation is failing on both my Linux computers just like in #4257 , so unfortunately I can't make it.

@keewis
Copy link
Collaborator

keewis commented Mar 15, 2021

you could also use the CI to verify the changes (the doctests CI is pretty fast), but as I said we can leave that to a new PR.

Unless someone else has any comments I'll merge this tomorrow.

@pep8speaks
Copy link

pep8speaks commented Mar 15, 2021

Hello @gabriel-abrahao! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-15 13:46:59 UTC

@gabriel-abrahao
Copy link
Contributor Author

you could also use the CI to verify the changes (the doctests CI is pretty fast), but as I said we can leave that to a new PR.

Unless someone else has any comments I'll merge this tomorrow.

Just did that, thanks! Is there a way to make the CI run just the check I want it to?

I'm not sure if every doctest has to import xarray as xr and import numpy as np, so I added those just in case and it's passing.

Also, right multiplying matrices will be deprecated in numpy, so now transform is on the left side.

Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks great.

Is there a way to make the CI run just the check I want it to?

for future reference, you can add a [skip-ci] tag to the first line of a commit message. This will run only the style and doctest checks and build the docs.

xarray/backends/rasterio_.py Outdated Show resolved Hide resolved
xarray/backends/rasterio_.py Outdated Show resolved Hide resolved
@keewis
Copy link
Collaborator

keewis commented Mar 15, 2021

thanks for the update, @gabriel-abrahao. I noticed this is you first PR here. Welcome to xarray!

@keewis keewis merged commit 2b06287 into pydata:master Mar 15, 2021
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 18, 2021
…indow

* upstream/master:
  Fix regression in decoding large standard calendar times (pydata#5050)
  Fix sticky sidebar responsiveness on small screens (pydata#5039)
  Flexible indexes refactoring notes (pydata#4979)
  add a install xarray step to the upstream-dev CI (pydata#5044)
  Adds Dataset.query() method, analogous to pandas DataFrame.query() (pydata#4984)
  run tests on python 3.9 (pydata#5040)
  Add date attribute to datetime accessor (pydata#4994)
  📚 New theme & rearrangement of the docs (pydata#4835)
  upgrade ci-trigger to the most recent version (pydata#5037)
  GH5005 fix documentation on open_rasterio (pydata#5021)
  GHA for automatically canceling previous CI runs (pydata#5025)
  Implement GroupBy.__getitem__ (pydata#3691)
  conventions: decode unsigned integers to signed if _Unsigned=false (pydata#4966)
  Added support for numpy.bool_ (pydata#4986)
  Add additional str accessor methods for DataArray (pydata#4622)
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 23, 2021
…-tasks

* upstream/master:
  Fix regression in decoding large standard calendar times (pydata#5050)
  Fix sticky sidebar responsiveness on small screens (pydata#5039)
  Flexible indexes refactoring notes (pydata#4979)
  add a install xarray step to the upstream-dev CI (pydata#5044)
  Adds Dataset.query() method, analogous to pandas DataFrame.query() (pydata#4984)
  run tests on python 3.9 (pydata#5040)
  Add date attribute to datetime accessor (pydata#4994)
  📚 New theme & rearrangement of the docs (pydata#4835)
  upgrade ci-trigger to the most recent version (pydata#5037)
  GH5005 fix documentation on open_rasterio (pydata#5021)
  GHA for automatically canceling previous CI runs (pydata#5025)
  Implement GroupBy.__getitem__ (pydata#3691)
  conventions: decode unsigned integers to signed if _Unsigned=false (pydata#4966)
  Added support for numpy.bool_ (pydata#4986)
  Add additional str accessor methods for DataArray (pydata#4622)
  add polyval to polyfit see also (pydata#5020)
  mention map_blocks in the docstring of apply_ufunc (pydata#5011)
  Switch backend API to v2 (pydata#4989)
  WIP: add new backend api documentation (pydata#4810)
  pin netCDF4=1.5.3 in min-all-deps (pydata#4982)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example documentation in open_rasterio
3 participants