Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up localize #8536

Merged
merged 2 commits into from
May 6, 2024
Merged

Speed up localize #8536

merged 2 commits into from
May 6, 2024

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Dec 10, 2023

A small performance improvement to _localize which is called during interpolation.

@Illviljan
Copy link
Contributor Author

get_indexer is quite heavy. Anyone got any ideas how to remove it?

@Illviljan Illviljan added topic-performance run-benchmark Run the ASV benchmark workflow labels Dec 10, 2023
@mathause
Copy link
Collaborator

mathause commented May 4, 2024

get_indexer is quite heavy. Anyone got any ideas how to remove it?

Unfortunately not, but this would be a small win in any case, no? Should we merge?

@Illviljan Illviljan marked this pull request as ready for review May 5, 2024 11:07
@Illviljan
Copy link
Contributor Author

Sure, we can merge. I think I just lost steam on this PR when there was no obvious alternative to get_indexer.

@mathause mathause merged commit faa6345 into pydata:main May 6, 2024
28 checks passed
@mathause
Copy link
Collaborator

mathause commented May 6, 2024

Thanks!

andersy005 pushed a commit that referenced this pull request May 10, 2024
Co-authored-by: Mathias Hauser <[email protected]>
andersy005 added a commit that referenced this pull request May 10, 2024
* main:
  Avoid auto creation of indexes in concat (#8872)
  Fix benchmark CI (#9013)
  Avoid extra read from disk when creating Pandas Index. (#8893)
  Add a benchmark to monitor performance for large dataset indexing (#9012)
  Zarr: Optimize `region="auto"` detection (#8997)
  Trigger CI only if code files are modified. (#9006)
  Fix for ruff 0.4.3 (#9007)
  Port negative frequency fix for `pandas.date_range` to `cftime_range` (#8999)
  Bump codecov/codecov-action from 4.3.0 to 4.3.1 in the actions group (#9004)
  Speed up localize (#8536)
  Simplify fast path (#9001)
  Add argument check_dims to assert_allclose to allow transposed inputs (#5733) (#8991)
  Fix syntax error in test related to cupy (#9000)
andersy005 added a commit to hmaarrfk/xarray that referenced this pull request May 10, 2024
* backend-indexing:
  Trigger CI only if code files are modified. (pydata#9006)
  Enable explicit use of key tuples (instead of *Indexer objects) in indexing adapters and explicitly indexed arrays (pydata#8870)
  add `.oindex` and `.vindex` to `BackendArray` (pydata#8885)
  temporary enable CI triggers on feature branch
  Avoid auto creation of indexes in concat (pydata#8872)
  Fix benchmark CI (pydata#9013)
  Avoid extra read from disk when creating Pandas Index. (pydata#8893)
  Add a benchmark to monitor performance for large dataset indexing (pydata#9012)
  Zarr: Optimize `region="auto"` detection (pydata#8997)
  Trigger CI only if code files are modified. (pydata#9006)
  Fix for ruff 0.4.3 (pydata#9007)
  Port negative frequency fix for `pandas.date_range` to `cftime_range` (pydata#8999)
  Bump codecov/codecov-action from 4.3.0 to 4.3.1 in the actions group (pydata#9004)
  Speed up localize (pydata#8536)
  Simplify fast path (pydata#9001)
  Add argument check_dims to assert_allclose to allow transposed inputs (pydata#5733) (pydata#8991)
  Fix syntax error in test related to cupy (pydata#9000)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmark Run the ASV benchmark workflow topic-performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants