Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate treenode module. #8757

Merged
merged 25 commits into from
Feb 27, 2024
Merged

Migrate treenode module. #8757

merged 25 commits into from
Feb 27, 2024

Commits on Feb 15, 2024

  1. Update the formating tests 

    PR (#8702) added nbytes representation in DataArrays and Dataset repr, this adds it to the datatree tests.
    @flamingbear
    flamingbear committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    065db0e View commit details
    Browse the repository at this point in the history

  2. Migrate treenode module 

    Moves treenode.py and test_treenode.py.
Updates some typing.
Updates imports from treenode.
    @flamingbear
    flamingbear committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    f167b99 View commit details
    Browse the repository at this point in the history

  3. Update NotFoundInTreeError description.

    @flamingbear
    flamingbear committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    6bd492f View commit details
    Browse the repository at this point in the history

  4. Reformat some comments 

    Add test tree structure for easier understanding.
    @flamingbear
    flamingbear committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    b62a21a View commit details
    Browse the repository at this point in the history

  5. Updates whats-new.rst

    @flamingbear
    flamingbear committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    32053b6 View commit details
    Browse the repository at this point in the history

  6. mypy typing. (terrible?) 

    There must be a better way, but I don't know it.
particularly the list comprehension casts.
    @flamingbear
    flamingbear committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    32e7453 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Adds __repr__ to NamedNode and updates test 

    This test was broken becuase only the root node was being tested and none of
the previous nodes were represented in the __str__.
    @flamingbear
    flamingbear committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    7f2a178 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'pydata/main' into mhs/migrate_treenode

    @flamingbear
    flamingbear committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    b4fb773 View commit details
    Browse the repository at this point in the history

  3. Adds quotes to NamedNode __str__ representation.

    @flamingbear
    flamingbear committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    548536b View commit details
    Browse the repository at this point in the history

  4. swaps " for ' in NamedNode __str__ representation.

    @flamingbear
    flamingbear committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    b9685d7 View commit details
    Browse the repository at this point in the history

  5. Adding Tom in so he gets blamed properly.

    @flamingbear
    flamingbear committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    59da654 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Merge remote-tracking branch 'pydata/main' into mhs/migrate_treenode

    @flamingbear
    flamingbear committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b821fca View commit details
    Browse the repository at this point in the history

  2. resolve conflict whats-new.rst 

    Question is I did update below the released line to give Tom some credit.  I
hope that's is allowable.
    @flamingbear
    flamingbear committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    4530973 View commit details
    Browse the repository at this point in the history

  3. Moves test_treenode.py to xarray/tests. 

    Integrated tests.
    @flamingbear
    flamingbear committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    c03d373 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Merge branch 'main' into mhs/migrate_treenode

    @flamingbear
    flamingbear authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ccd5374 View commit details
    Browse the repository at this point in the history

  2. refactors backend tests for datatree IO

    @flamingbear
    flamingbear committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    4830cd4 View commit details
    Browse the repository at this point in the history

  3. Add explicit engine back in test_to_zarr

    @flamingbear
    flamingbear committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    e8459bc View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Removes OrderedDict from treenode

    @flamingbear
    flamingbear committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    4238ce2 View commit details
    Browse the repository at this point in the history

  2. Renames tests/test_io.py -> tests/test_backends_datatree.py

    @flamingbear
    flamingbear committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    db264c0 View commit details
    Browse the repository at this point in the history

  3. typo

    @flamingbear
    flamingbear authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    b4acb0d View commit details
    Browse the repository at this point in the history

  4. Add types

    @flamingbear
    flamingbear committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    0f4b38a View commit details
    Browse the repository at this point in the history

  5. Merge pull request #7 from flamingbear/mhs/migrate-datatree-tests

    @flamingbear
    flamingbear authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    e7ea2b4 View commit details
    Browse the repository at this point in the history

  6. Pass mypy for 3.9

    @flamingbear
    flamingbear committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    f2f327f View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Merge branch 'main' into mhs/migrate_treenode

    @flamingbear
    flamingbear authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    9cbaf3b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mhs/migrate_treenode

    @flamingbear
    flamingbear authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    9db7040 View commit details
    Browse the repository at this point in the history