Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groupby: remove some internal use of IndexVariable #9123

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

dcherian
Copy link
Contributor

Builds on #9122 removes internal use of IndexVariable

Toward #8840

@dcherian dcherian changed the title Groupby remove index variable Groupby remove use of IndexVariable Jun 14, 2024
@dcherian dcherian changed the title Groupby remove use of IndexVariable groupby: remove some internaluse of IndexVariable Jun 14, 2024
@dcherian dcherian changed the title groupby: remove some internaluse of IndexVariable groupby: remove some internal use of IndexVariable Jun 14, 2024
@dcherian dcherian mentioned this pull request Jun 14, 2024
5 tasks
@dcherian dcherian force-pushed the groupby-remove-index-variable branch from 8514a9e to fc85ba2 Compare June 14, 2024 19:52
@dcherian dcherian marked this pull request as ready for review June 14, 2024 21:22
@dcherian dcherian added plan to merge Final call for comments and removed needs review labels Jun 21, 2024
* main:
  Split out distributed writes in zarr docs (pydata#9132)
  Update zendoo badge link (pydata#9133)
  Support duplicate dimensions in `.chunk` (pydata#9099)
  Bump the actions group with 2 updates (pydata#9130)
  adjust repr tests to account for different platforms (pydata#9127) (pydata#9128)
@dcherian
Copy link
Contributor Author

Going to merge since this is purely internal. Now IndexVariable is only accepted as an input to GroupBy!

@dcherian dcherian merged commit 2645d7f into pydata:main Jun 21, 2024
28 checks passed
@dcherian dcherian deleted the groupby-remove-index-variable branch June 21, 2024 22:35
dcherian added a commit that referenced this pull request Jul 24, 2024
* main: (48 commits)
  Add test for #9155 (#9161)
  Remove mypy exclusions for a couple more libraries (#9160)
  Include numbagg in type checks (#9159)
  Improve zarr chunks docs (#9140)
  groupby: remove some internal use of IndexVariable (#9123)
  Improve `to_zarr` docs (#9139)
  Split out distributed writes in zarr docs (#9132)
  Update zendoo badge link (#9133)
  Support duplicate dimensions in `.chunk` (#9099)
  Bump the actions group with 2 updates (#9130)
  adjust repr tests to account for different platforms (#9127) (#9128)
  Grouper refactor (#9122)
  Update docstring in api.py for open_mfdataset(), clarifying "chunks" argument (#9121)
  Add test for rechunking to a size string (#9117)
  Move Sphinx directives out of `See also` (#8466)
  new whats-new section (#9115)
  release v2024.06.0 (#9113)
  release notes for 2024.06.0 (#9092)
  [skip-ci] Try fixing hypothesis CI trigger (#9112)
  Undo custom padding-top. (#9107)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant