switch the documentation to run with numpy>=2
#9177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2024
|
Thank you v much for doing these @keewis |
and mention that we're falling back to `numpy.array_api` in `numpy<2.0`
JessicaS11
approved these changes
Jun 28, 2024
1 task
dcherian
reviewed
Jul 2, 2024
keewis
commented
Jul 11, 2024
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Jul 11, 2024
* main: exclude the bots from the release notes (pydata#9235) switch the documentation to run with `numpy>=2` (pydata#9177) `numpy` 2 compatibility in the iris code paths (pydata#9156) `numpy` 2 compatibility in the `netcdf4` and `h5netcdf` backends (pydata#9136) Fix time indexing regression in `convert_calendar` (pydata#9192) Use duckarray assertions in test_coding_times (pydata#9226) Use reshape and ravel from duck_array_ops in coding/times.py (pydata#9225) Cleanup test_coding_times.py (pydata#9223) Only use necessary dims when creating temporary dataarray (pydata#9206) Fix two bugs in DataTree.update() (pydata#9214) Use numpy 2.0-compat `np.complex64` dtype in test (pydata#9217)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctests can't really support backwards compatibility with older versions of
numpy– thereprof scalars was changed – so with this we basically stop supporting builds of the docs and running the doctests withnumpy<2.0. I don't think that's an issue, though.For
crosswe'll need to decide what to do...numpy>=2.0stopped supportingdeprecatednp.crosson 2D arrays, and in #8993 I simply removed the tests for 2D arrays from the tests. If we do that here, as well, we'll have to modify the docstring. Another option would be to zero-pad to 3-dimensional.I avoided a deciding on
np.linspace(da1_0d, da2_0d, n)(see #9043) by extracting the value using.item().Other than that, there seems to be an issue inseems like my environment was the issue? CI doesn't fail, at least.to_dask_dataframe, which I'm still investigating.This is waiting on #9136
whats-new.rst