Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure TreeNode doesn't copy in-place #9482

Merged
merged 13 commits into from
Sep 12, 2024
Merged

Ensure TreeNode doesn't copy in-place #9482

merged 13 commits into from
Sep 12, 2024

Commits on Sep 11, 2024

  1. test from pydata#9196 but on TreeNode

    @TomNicholas
    TomNicholas committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a0af2ac View commit details
    Browse the repository at this point in the history

  2. move assignment and copying of children to TreeNode constructor

    @TomNicholas
    TomNicholas committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    104d80e View commit details
    Browse the repository at this point in the history

  3. move copy methods over to TreeNode

    @TomNicholas
    TomNicholas committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9e02ae2 View commit details
    Browse the repository at this point in the history

  4. change copying behaviour to be in line with pydata#9196

    @TomNicholas
    TomNicholas committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d3629bb View commit details
    Browse the repository at this point in the history

  5. explicitly test that ._copy_subtree works for TreeNode

    @TomNicholas
    TomNicholas committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f8ee2a7 View commit details
    Browse the repository at this point in the history

  6. reimplement ._copy_subtree using recursion

    @TomNicholas
    TomNicholas committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    6231c7c View commit details
    Browse the repository at this point in the history

  7. change treenode.py tests to match expected non-in-place behaviour

    @TomNicholas
    TomNicholas committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5ece6e8 View commit details
    Browse the repository at this point in the history

  8. fix but created in DataTree.__init__

    @TomNicholas
    TomNicholas committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ea61a95 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into treenode_copy

    @TomNicholas
    TomNicholas committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1aa9820 View commit details
    Browse the repository at this point in the history

  10. add type hints for Generic TreeNode back in

    @TomNicholas
    TomNicholas committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9c328a0 View commit details
    Browse the repository at this point in the history

  11. update typing of ._copy_node

    @TomNicholas
    TomNicholas committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b1f66e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. remove redunant setting of _name

    @TomNicholas
    TomNicholas committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3a1f372 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into treenode_copy

    @TomNicholas
    TomNicholas committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e3a8b30 View commit details
    Browse the repository at this point in the history