-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify c-side of events sub-module. (Part 1) #3000
base: main
Are you sure you want to change the base?
Conversation
…into events-in-python
First of all, I'd like to say that I love where this is going :)
Tell me what you think about this |
@damusss Thanks for the comment - I'll update |
Alright, I'll check the stub situation when you are closer to finish then. Nice work so far :> |
(Why the commits duplicated after I resolved merge conflict?) |
No actually why are part of the commits not yours?? what even happened? It looks like you are adding the deprecator decorator |
I merged commits from upstream using |
b808ac9
to
931cf5e
Compare
Done, even though they still appear in the conversation, I removed them from the commits tab (I guess that conversation side just logs every change and not exactly those that truly will be merged?). |
I think I'll split this PR in two parts:
|
…into events-in-python
…into events-in-python
This PR moves some of functionality from c to python.