Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pygame.typing.Coordinate to Point, fix related grammar #3139

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

aatle
Copy link
Contributor

@aatle aatle commented Oct 3, 2024

As per discussion on discord, the Coordinate class is grammatically incorrect and Point would be a better name for various reasons.

Rename Coordinate to Point and IntCoordinate to IntPoint in code. Mostly in .pyi files, and a few test modules.
(Non-python code was not checked.)

Fix grammar where "coordinate" was put when "point" or "coordinates" was intended, in pygame docs.

@aatle aatle requested a review from a team as a code owner October 3, 2024 23:39
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing 🎉

Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just a small typo to fix 💀

docs/reST/ref/gfxdraw.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bilhox bilhox merged commit 1a28571 into pygame-community:main Oct 4, 2024
25 checks passed
@aatle aatle deleted the rename-coordinate branch October 4, 2024 19:40
@ankith26 ankith26 added this to the 2.5.2 milestone Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants