-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meson flag for compiling with SDL3 #3141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, looks good! 👍
Converting to draft because I want to do a bit more in this PR |
|
This PR is now done from my end |
With regards to the include changes, in my development I've just made sure the include path goes inside the SDL folder instead of editing every include. |
Another thing I did in my branch to make this stuff compile better was Also because of my prior PRs several modules you've masked out in this compile, at least last time I checked (may have changed). Like key, image, base, etc. |
The latest changes have broken some of your patches. For instance,
That was my first idea but it is virtually impossible to do from our end in a cross platform way (see my older comment with the link to the SDL issue). |
My first reaction: oh boy 😢 However-- We can use macros on the pixelformat itself,
I don't know anything about .pc files. It makes me annoyed at meson that we don't have the freedom to do that. It seems like we should be able to add an include path to an existing dependency object, which would solve this because we could add an include path which is the old include path + "/sdl3". |
Even if we could do that, we would probably not be able to support macOS Frameworks: for reasons I don't understand. |
It's so easy on Windows with the old SETUP file that I didn't even bat an eye when I rewrote the include path. |
Add a flag to allow compilation with SDL3. But for obvious reasons we still default to compiling with SDL2.