Add support for complex() using __complex__
#3185
Conversation
bilhox
added
New API
src_c/math.c
Outdated
| PyComplex_FromDoubles(self->coords[0], self->coords[1]); | ||
|
|
||
| if (complex == NULL) { | ||
| RAISE(PyExc_ValueError, "Couldn't build complex number from Vector2"); |
There was a problem hiding this comment.
This should be return RAISE
There was a problem hiding this comment.
This whole function can just be return PyComplex_FromDoubles(self->coords[0], self->coords[1]); because the function already sets the python exception on error, we don't need to set an error ourselves
There was a problem hiding this comment.
I don't see the point of adding API for something that can be done in user code by typing just one more character than what this PR makes possible.
a = pygame.Vector2(1, 2)
complex(*a)
Bonus of complex(*a) is that it actually works on any 2-sized sequence like a tuple of list of numbers, which is also something some people use to represent coordinates instead of Vector2
src_c/math.c
Outdated
| PyComplex_FromDoubles(self->coords[0], self->coords[1]); | ||
|
|
||
| if (complex == NULL) { | ||
| RAISE(PyExc_ValueError, "Couldn't build complex number from Vector2"); |
There was a problem hiding this comment.
This whole function can just be return PyComplex_FromDoubles(self->coords[0], self->coords[1]); because the function already sets the python exception on error, we don't need to set an error ourselves
It's one character less than what you proposed, which is still better. And also I think the tools |
|
Also, we have had debates about it in the past and back then we had consensus that it was not needed, atleast among the active reviewers at the time: #1515 |
|
With a lot of denial, I'm closing this PR. |
This PR overloads the method
__complex__so you can convert a vector2 to a complex number usingcomplex().The usage ? Math only, definitely.
I'm supporting this PR as I know a lot of people using pygame for a non gamedev usage.