Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better rect tests using literal values #3190

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+28 −28
Open

better rect tests using literal values #3190

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1932b82
Changes to be commited:
Oct 16, 2024
49dbee5
Delete test.txt
GabrieleLS Oct 16, 2024
969cdce
Fix functions in rect_test to use literal values for attribute checks
AntoineMamou Oct 23, 2024
79eabb1
Merge branch 'pygame-community:main' into rect_test
AntoineMamou Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions test/rect_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,27 +777,27 @@ def test_inflate__larger(self):
r = Rect(2, 4, 6, 8)
r2 = r.inflate(4, 6)

self.assertEqual(r.center, r2.center)
self.assertEqual(r.left - 2, r2.left)
self.assertEqual(r.top - 3, r2.top)
self.assertEqual(r.right + 2, r2.right)
self.assertEqual(r.bottom + 3, r2.bottom)
self.assertEqual(r.width + 4, r2.width)
self.assertEqual(r.height + 6, r2.height)
self.assertEqual(r2.center, (5, 8))
self.assertEqual(r2.left, 0)
self.assertEqual(r2.top, 1)
self.assertEqual(r2.right, 10)
self.assertEqual(r2.bottom, 15)
self.assertEqual(r2.width, 10)
self.assertEqual(r2.height, 14)

def test_inflate__smaller(self):
"""Ensures deflating a rect keeps its center the same
and shrinks dimensions by correct values."""
r = Rect(2, 4, 6, 8)
r2 = r.inflate(-4, -6)

self.assertEqual(r.center, r2.center)
self.assertEqual(r.left + 2, r2.left)
self.assertEqual(r.top + 3, r2.top)
self.assertEqual(r.right - 2, r2.right)
self.assertEqual(r.bottom - 3, r2.bottom)
self.assertEqual(r.width - 4, r2.width)
self.assertEqual(r.height - 6, r2.height)
self.assertEqual((5, 8), r2.center)
self.assertEqual(4, r2.left)
self.assertEqual(7, r2.top)
self.assertEqual(6, r2.right)
self.assertEqual(9, r2.bottom)
self.assertEqual(2, r2.width)
self.assertEqual(2, r2.height)
Comment on lines +794 to +800
Copy link
Contributor

@gresm gresm Nov 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some whitespace snuck by. I recommend using autoformatting tools to fix that.
You can either:

pip install pre-commit
pre-commit run -a
pre-commit install  # completely optional, will cause the pre-commit to run every time you make a commit.

Or

python dev.py format

Both I recommend running in a virtualenv.


def test_inflate_ip__larger(self):
"""Ensures inflating a rect in place keeps its center the same
Expand All @@ -806,13 +806,13 @@ def test_inflate_ip__larger(self):
r2 = Rect(r)
r2.inflate_ip(4, 6)

self.assertEqual(r.center, r2.center)
self.assertEqual(r.left - 2, r2.left)
self.assertEqual(r.top - 3, r2.top)
self.assertEqual(r.right + 2, r2.right)
self.assertEqual(r.bottom + 3, r2.bottom)
self.assertEqual(r.width + 4, r2.width)
self.assertEqual(r.height + 6, r2.height)
self.assertEqual(r2.center, (5, 8))
self.assertEqual(r2.left, 0)
self.assertEqual(r2.top, 1)
self.assertEqual(r2.right, 10)
self.assertEqual(r2.bottom, 15)
self.assertEqual(r2.width, 10)
self.assertEqual(r2.height, 14)

def test_inflate_ip__smaller(self):
"""Ensures deflating a rect in place keeps its center the same
Expand All @@ -821,13 +821,13 @@ def test_inflate_ip__smaller(self):
r2 = Rect(r)
r2.inflate_ip(-4, -6)

self.assertEqual(r.center, r2.center)
self.assertEqual(r.left + 2, r2.left)
self.assertEqual(r.top + 3, r2.top)
self.assertEqual(r.right - 2, r2.right)
self.assertEqual(r.bottom - 3, r2.bottom)
self.assertEqual(r.width - 4, r2.width)
self.assertEqual(r.height - 6, r2.height)
self.assertEqual(r2.center, (5, 8))
self.assertEqual(r2.left, 4)
self.assertEqual(r2.top, 7)
self.assertEqual(r2.right, 6)
self.assertEqual(r2.bottom, 9)
self.assertEqual(r2.width, 2)
self.assertEqual(r2.height, 2)

def test_scale_by__larger_single_argument(self):
"""The scale method scales around the center of the rectangle"""
Expand Down
Loading