Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add what is netlify to README and corrected broken organizers images link #1

Merged
merged 3 commits into from
Jul 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
<!--
Please document the following for your pull request.
-->

# PyLadies Website Pull Request
_Please document the following. We will aim to be as timely as possible in processing your pull request, however as this is a volunteer staffed project anticipate at least a week for pull requests to start to be reviewed._

## Is this pull requesting adding or updating a [PyLadies chapter information](https://github.com/pyladies/pyladies#to-add-a-new-pyladies-location)?
<!--
Example of response:

Mark which one is correct.
-->

- [ ] Yes
- [ ] No

### If you marked yes, is this chapter registered in the PyLadies Chapter Directory?
<!--
Example of response:

Mark which one is correct.
-->

- [ ] Yes
- [ ] No

### If you marked no, please register your chapter using the following form [here](https://forms.gle/LYT6TzjgJ437Y4mr8). The form can only be accessed by being logged into your official PyLadies email account. Were you able to complete the registration?
<!--
Example of response:

Mark which one is correct. If `No` please detail why you cannot complete the registration.
-->

- [ ] Yes
- [ ] No, I could not because [add response below]:


## Have you confirmed the website builds locally with your chapters? See [here](https://github.com/pyladies/pyladies/netlify-website-template/README.md).
<!--
Example of response:

Mark which one is correct. Include a screen shot confirming the website builds with your changes.
-->

- [ ] Yes
- [ ] No

## Does the Netlify preview look correct? Confirm in the checks below on the netlify/deploy-preview check.
<!--
Example of response:

Mark which one is correct. Include a screen shot confirming the website builds with your changes.
-->

- [ ] Yes
- [ ] No

<!--
Add any other team you think should be subscribed to this issue

/cc your team
-->
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# netlify-website-template

Example of PyLadies Website theme powered by Netlify.
Example of PyLadies Website theme powered by Netlify with [a standard pull request template](github.com/pyladies/netlify-website-template/PULL_REQUEST_TEMPLATE). You can preview the template [here](https://distracted-payne-504b82.netlify.app/).

## What is Netlify?

Netlify is a simple tool to use for continuous integration and continuous development. It allows you to specify custom build commands as well as run specific tests and pull request to specific branches you specify. You can additionally get a deploy preview of your website capturing the changes generated in a pull request on a Netlify hosted url.

## Setting up you website with Netlify

Expand Down
4 changes: 2 additions & 2 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ <h2 class="col-sm-12 text-center">Events</h2>
<h4>Organizers</h4>
<img src="./images/line.svg" class="hr-squiggle">
<div class="bio-container">
<div class="organizer-container"><img src="./images/bios/pylady_geek.jpeg" class="organizer landscape" /></div>
<div class="organizer-container"><img src="./images/bios/pylady_geek.png" class="organizer landscape" /></div>
<div class="bio">
<p class="name">Organizer 1</p>
<p>
Expand All @@ -99,7 +99,7 @@ <h4>Organizers</h4>
</div>
<div class="bio-container">
<div class="organizer-container">
<img src="./images/bios/pylady_geek.jpeg" class="organizer" />
<img src="./images/bios/pylady_geek.png" class="organizer" />
</div>
<div class="bio">
<p class="name">Organizer 2</p>
Expand Down