Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setuptools dependency to fix test_identify_old_namespace_package_protocol #2558

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

akamat10
Copy link
Contributor

@akamat10 akamat10 commented Sep 9, 2024

Type of Changes

Type
βœ“ πŸ› Bug fix
βœ“ πŸ”¨ Refactoring

Description

See the following failure when running tests in python3.12

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    import warnings
    
    with warnings.catch_warnings():
        warnings.simplefilter("ignore", DeprecationWarning)
>       __import__("pkg_resources").declare_namespace(__name__)
E       ModuleNotFoundError: No module named 'pkg_resources'

testdata/python3/data/path_pkg_resources_1/package/__init__.py:5: ModuleNotFoundError

==================================== short test summary info =====================================
FAILED test_manager.py::AstroidManagerTest::test_identify_old_namespace_package_protocol - ModuleNotFoundError: No module named 'pkg_resources'

Looks the dependency was incorrectly changed in 590498d. I also removed the implicit setuptools dependency as part of this. Not sure if wheel should also be moved to the requirements file. So I left it as is.

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 92.98%. Comparing base (7954bac) to head (4dad65b).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2558   +/-   ##
=======================================
  Coverage   92.97%   92.98%           
=======================================
  Files          93       93           
  Lines       11081    11083    +2     
=======================================
+ Hits        10303    10305    +2     
  Misses        778      778           
Flag Coverage Ξ”
linux 92.86% <ΓΈ> (+<0.01%) ⬆️
pypy 92.98% <ΓΈ> (+<0.01%) ⬆️
windows 92.96% <ΓΈ> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@akamat10 akamat10 marked this pull request as ready for review September 10, 2024 12:34
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah, I think it makes more sense this way. Let's wait for @jacobtylerwalls opinion rhough.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.4.0 milestone Sep 12, 2024
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, thank you!

@jacobtylerwalls jacobtylerwalls merged commit c7b8a2f into pylint-dev:main Sep 12, 2024
21 checks passed
@jacobtylerwalls jacobtylerwalls modified the milestones: 3.4.0, 4.0.0 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants