fix issue when inferring single-node or non-const JoinedStr #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #2578 +/- ##
==========================================
- Coverage 93.10% 93.10% -0.01%
==========================================
Files 93 93
Lines 11067 11065 -2
==========================================
- Hits 10304 10302 -2
Misses 763 763
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jacobtylerwalls
approved these changes
Sep 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
(cherry picked from commit 8585ce6)
jacobtylerwalls
pushed a commit
that referenced
this pull request
Sep 23, 2024
β¦2579) (cherry picked from commit 8585ce6) Co-authored-by: Eric Vergnaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Supports inference of single-node and non-const JoinedStr
Fixes #9947