Move typing imports and some definitions behind guard #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdrozd
force-pushed
the
unguarded-typing-import
branch
from
21defbc
to
37f0fc5
Compare
for more information, see https://pre-commit.ci
|
Lot of work on this one, nice 🔥 I'm going to benchmark this when I find the time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Taking pylint-dev/pylint#9964 for a spin. Idea here is that imports that are only used for typechecking should only be imported for typechecking. This will clarify module dependency structure and possibly also reduce startup time and memory use. Pylint / Astroid is slow and complicated, so this sort of change will feed two birds with one scone.
Mostly this changes imports. There are also some type definitions that are used only for typechecking. The new checker doesn't look at those (yet), so they have not been systematically moved under the type guard. But ultimately they should be.