disable AsyncGeneratorModel from inheriting Generator attributes #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temyurchenko
force-pushed
the
decouple-async-from-sync
branch
from
deb97f1
to
e8534dc
Compare
for example, usual generators have "send", but async don't. They have "async" instead.
temyurchenko
force-pushed
the
decouple-async-from-sync
branch
from
e8534dc
to
611c622
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2587 +/- ##
==========================================
- Coverage 93.24% 93.23% -0.01%
==========================================
Files 93 93
Lines 11067 11060 -7
==========================================
- Hits 10319 10312 -7
Misses 748 748
Flags with carried forward coverage won't be shown. Click here to find out more.
|
DanielNoord
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for example, usual generators have "send", but async don't. They have
"asend" instead.
Type of Changes
Description
Fixes a test in pylint, which failed following #2584