Remove unused numpy utility functions #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2595 +/- ##
==========================================
+ Coverage 93.19% 93.22% +0.03%
==========================================
Files 93 93
Lines 11055 11048 -7
==========================================
- Hits 10303 10300 -3
+ Misses 752 748 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
DanielNoord
previously approved these changes
Oct 2, 2024
Follow-up to c7ea1e9.
correctmost
force-pushed
the
cm/remove-numpy-helpers
branch
from
5d74021
to
8d6fdcd
Compare
Pierre-Sassoulas
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Follow-up to c7ea1e9 and #2550.
I wasn't sure if more documentation or labeling was needed for changes that could impact backward compatibility.