False positives (especially on forms.py)

[chrisma]

We tried using landscape.io with this plugin.
Unfortunately, there seem to be false positives (especially concerning forms).
See for example here: https://landscape.io/github/hubx/EvaP/4/modules/evap/fsr/forms.py

[carlio]

Hi @chrisma, thanks for the bug report. This was two issues:

• A change in the internals of a newer version of pylint which caused some of the django workarounds to stop working. This has now been fixed (in this commit: pylint-dev/pylint-plugin-utils@0009c94). You'll see that https://landscape.io/github/hubx/EvaP/6/modules/evap/fsr/forms.py is much improved.
• pylint-django doesn't have anything special cases for using Form Field constructors, apparently. I will investigate further and figure out how to add that.

[chrisma]

Hey,
thanks for the quick fix. Looks good!
pylint-django dealing with form field constructors would be awesome.

[karyon]

i don't know exactly what the problem with the form field constructors was, but looking at our current code, it seems to be fixed in landscape:

https://landscape.io/github/fsr-itse/EvaP/130/modules/evap/fsr/forms.py

there is one error left in that file. i don't know whether that's an actual error in the code or another landscape fail.

[carlio]

I think that last remaining error is not Landscape but rather Pylint. It seems like it's warning because the class passed to super is not the direct parent, but rather the grandparent. I don't know if this is a bug or a warning, but it's in pylint proper rather than this plugin so I'll close this issue.

[karyon]

it seems this bug came back, see https://landscape.io/github/fsr-itse/EvaP/146/modules/evap/fsr/forms.py

[karyon]

should i file a new bug for this?

[carlio]

Hi @karyon - it's still not fixed, because it's still a problem in pylint/astroid - see https://bitbucket.org/logilab/pylint/issue/24/e1002-message-for-djangoformsmodelform . Unfortunately it's proving to be a difficult thing to fix! However it's upstream from pylint-django so please leave this issue closed.

[karyon]

i'm sorry if i was unclear, but by "this bug came back" i meant that all the false positives in our forms came back. please have a look at https://landscape.io/github/fsr-itse/EvaP/146/modules/evap/fsr/forms.py, my problem should be immediately clear.

[carlio]

@karyon Sorry I misunderstood.

I investigated further and it seems like the problem is because Django was not installed correctly in the Landscape checking environment. The score went from 90% to 63% from check 138 to check 143 and if you look on the requirements for 138 and the requirements for 143 you can see that Django stopped installing correctly then.

I don't know why this is, I will look into it. This is a Landscape bug however, so I have opened a new issue here: landscapeio/landscape-issues#88

[karyon]

thanks for looking into this!