Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests should not be installed, or find_packages() is incorrectly defined #129

Closed
moubctez opened this issue Feb 27, 2018 · 4 comments
Closed

Comments

@moubctez
Copy link

I think pylint-django should not install tests (for sure, not under .../site-packages/test directory). Please, apply this patch to omit test installation.

--- setup.py.orig
+++ setup.py
@@ -7,10 +7,8 @@ from setuptools import setup, find_packa
 
 VERSION = '0.9.1'
 PACKAGES = find_packages(exclude=[
-    '*.tests',
-    '*.tests.*',
-    'tests.*',
-    'tests',
+    'test.*',
+    'test',
 ])
 
 SHORT_DESCRIPTION = 'A Pylint plugin to help Pylint understand the Django web framework'
@atodorov
Copy link
Contributor

That would conflict with #128

@aerostitch how does not installing tests affect Debian packaging ?

@atodorov
Copy link
Contributor

I think a simpler patch will work for both use cases:

-    packages=PACKAGES,
+    packages=['pylint_django'],

Thoughts ?

@aerostitch
Copy link
Contributor

Well I do need the tests in the pypi package, but they don't necessarily need to be in site-packages. :)
Where would the tests be distributed in that case @atodorov ?

@atodorov
Copy link
Contributor

I want to move the tests directory under pylint_django so that when pip installs the package the layout is site-packages/pylint_django/tests.

Otherwise we get a site-packages/tests directory which is bad (i.e you can do import tests).

I don't think my initial proposal works though so I have to look at it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants