Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple packaging fixes #137

Merged
merged 7 commits into from
Mar 12, 2018
Merged

Multiple packaging fixes #137

merged 7 commits into from
Mar 12, 2018

Commits on Mar 9, 2018

  1. Revert "List Django as a dependency. Fix #96" 

    This reverts commit 9b520e9.

Apparently this is causing more problems than it solves, see:
#132
    @atodorov
    atodorov committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    bb41fd7 View commit details
    Browse the repository at this point in the history

  2. Add optional dependency for Django and update README 

    This commit adds an optional dependency for Django for users who
would like to have Django installed automatically when installing
pylint-django.

It also updates the text in README and adds an ISSUE_TEMPLATE which
warns the users not to report bugs if Django is not installed
automatically!
    @atodorov
    atodorov committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    9aae2fe View commit details
    Browse the repository at this point in the history

  3. README formatting

    @atodorov
    atodorov committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    9cb7434 View commit details
    Browse the repository at this point in the history

  4. Remove unused import

    @atodorov
    atodorov committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    6e34b7a View commit details
    Browse the repository at this point in the history

  5. Let DjangoInstalledChecker warn when Django isn't available 

    by ignoring the import failure Python will not produce a traceback
but instead let DjangoInstalledChecker do its job and warn the user.

I also add a CI build stage to test this scenario since we don't want
to continue if this isn't working. NOTE: tox doesn't allow us to easily
execute shell scripts and commands outside its virtualenv so I have to
resort to ugly bash escaping to make this work!

Finally properly fixes #96.
    @atodorov
    atodorov committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    850bf83 View commit details
    Browse the repository at this point in the history

  6. Add test invoking pylint_django when Django has been installed 

    in this case we expect no errors for setup.py
    @atodorov
    atodorov committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    2dbcb18 View commit details
    Browse the repository at this point in the history

  7. Build packages and perform package sanity tests. Fixes #136

    @atodorov
    atodorov committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    58265d7 View commit details
    Browse the repository at this point in the history