Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ASGI #258

Merged
merged 4 commits into from
Feb 10, 2020
Merged

Support ASGI #258

merged 4 commits into from
Feb 10, 2020

Conversation

sanmai-NL
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Feb 9, 2020

Pull Request Test Coverage Report for Build 982

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.599%

Totals Coverage Status
Change from base Build 924: 0%
Covered Lines: 645
Relevant Lines: 728

💛 - Coveralls

@sanmai-NL
Copy link
Contributor Author

Any idea what's happening with the failed tests?

@carlio
Copy link
Collaborator

carlio commented Feb 10, 2020

You could try running them locally via tox or directly (https://github.com/PyCQA/pylint-django#tests) to see yourself.

It looks like there's a new error being raised that wasn't being raised before. That's possibly due to a new pylint release (last one was on Nov 19 but I'm not sure if anyone ran tests since then). The test output basically says that no-name-in-module is being reported by pylint on those test files which the tests were not expecting, not sure why that is but since your change was small I suspect it is caused from an upstream release or regression.

@carlio
Copy link
Collaborator

carlio commented Feb 10, 2020

@sanmai-NL Seems like @atodorov's PR will fix this : #260

@carlio
Copy link
Collaborator

carlio commented Feb 10, 2020

@sanmai-NL the previous errors are gone now thanks to #260. Can you run flake8 on it and fix those couple of formatting warnings? That's the only bit that's complaining now.

@sanmai-NL
Copy link
Contributor Author

@carlio: ready for squashing and merging.

@carlio
Copy link
Collaborator

carlio commented Feb 10, 2020

@sanmai-NL perfect thank you!

@atodorov do you have a release planned? I'll wait on #259 changes first, just don't want to step on your toes if you are doing anything.

@carlio carlio merged commit e8759a7 into pylint-dev:master Feb 10, 2020
@atodorov
Copy link
Contributor

@carlio I wasn't planning anything but I agree with you. Let's wait for #259 and release the 2 changes together. Let me know if you want me to build the new package.

@sanmai-NL sanmai-NL deleted the patch-1 branch February 10, 2020 14:05
@WayneLambert
Copy link
Contributor

Thanks for progressing these changes. Have you got another PyPI release planned shortly @atodorov and @carlio to account for the PRs #258 and #259?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants