Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error for gettext_lazy #262

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

Anto59290
Copy link
Contributor

@Anto59290 Anto59290 commented Mar 31, 2020

Hey :)

ugettext_lazy will soon be removed in favour of gettext_lazy. See https://docs.djangoproject.com/en/3.0/releases/3.0/#id3 for more details.

This fix a very similar issue to #80. We (with @rik) also added a test.

@coveralls
Copy link

coveralls commented Mar 31, 2020

Pull Request Test Coverage Report for Build 1034

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 88.477%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint_django/transforms/transforms/django_utils_translation.py 0 2 0.0%
Totals Coverage Status
Change from base Build 997: -0.1%
Covered Lines: 645
Relevant Lines: 729

💛 - Coveralls

Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit late on this but overall looks good, just need to make pylint happy.

ugettext_lazy will soon be removed in favour of gettext_lazy.
See https://docs.djangoproject.com/en/3.0/releases/3.0/#id3
@atodorov atodorov merged commit 7cfd7bf into pylint-dev:master Apr 14, 2020
@Anto59290
Copy link
Contributor Author

Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants