Suppress unused-argument for functions in migration modules #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
force-pushed
the
migrations_unused_arguments
branch
from
2575ef6
to
39d792b
Compare
Pull Request Test Coverage Report for Build 1130
💛 - Coveralls |
usually these are functions used in migrations.RunPython() but the suppression code is not that smart and will suppress any unused-argument which is triggered by functions defined inside a migrations module.
atodorov
force-pushed
the
migrations_unused_arguments
branch
from
39d792b
to
704e93c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usually these are functions used in migrations.RunPython() but
the suppression code is not that smart and will suppress any
unused-argument which is triggered by functions defined inside a
migrations module.
@carlio I've started using the new pylint_django.checkers.migrations in my own projects and started hitting this. What do you think ?