Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for .github/workflows/run-tests.yaml #14

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

stdedos
Copy link
Collaborator

@stdedos stdedos commented Oct 18, 2023

  • Configure action concurrency:
  • Use codecov/codecov-action@v3 flags (might ... help codecov, somehow)
  • Upload testing artifacts
  • Add the Codecov badge in the README.md

Signed-off-by: Stavros Ntentos [email protected]

* Configure action `concurrency:`
* Use `codecov/codecov-action@v3` flags (might ... help codecov, somehow)
* Upload testing artifacts
* Add the Codecov badge in the README.md

Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos
Copy link
Collaborator Author

stdedos commented Oct 18, 2023

Might help diagnose why https://app.codecov.io/gh/pylint-dev/pylint-pytest is totally missing pylint_pytest as a path

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (163ac3a) 87.82% compared to head (0b1bb86) 87.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   87.82%   87.82%           
=======================================
  Files          34       34           
  Lines         419      419           
  Branches       85       85           
=======================================
  Hits          368      368           
  Misses         48       48           
  Partials        3        3           
Flag Coverage Δ
3.10 87.82% <ø> (?)
3.11 87.82% <ø> (?)
3.6 87.82% <ø> (?)
3.7 87.82% <ø> (?)
3.8 87.82% <ø> (?)
3.9 87.82% <ø> (?)
macos-latest 87.82% <ø> (?)
ubuntu-20.04 87.79% <ø> (?)
ubuntu-latest 87.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the tests don't work anymore 😄

.github/workflows/run-tests.yaml Show resolved Hide resolved
.github/workflows/run-tests.yaml Show resolved Hide resolved
@stdedos stdedos mentioned this pull request Oct 18, 2023
@stdedos
Copy link
Collaborator Author

stdedos commented Oct 18, 2023

Tracked: #16 😢

@stdedos stdedos disabled auto-merge October 18, 2023 19:17
@stdedos stdedos merged commit 55e4218 into pylint-dev:master Oct 18, 2023
17 of 23 checks passed
@stdedos stdedos deleted the test/impr-action+coverage branch October 18, 2023 19:17
@stdedos stdedos added this to the Release v2 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants