Skip to content

Commit

Permalink
update msg id
Browse files Browse the repository at this point in the history
  • Loading branch information
clavedeluna committed Nov 18, 2022
1 parent dbf0c36 commit 6bd578f
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 6 deletions.
2 changes: 1 addition & 1 deletion doc/user_guide/checkers/extensions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ Verbatim name of the checker is ``dict-init-mutate``.

Dict-Init-Mutate checker Messages
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
:dict-init-mutate (W0170): *Dictionary mutated immediately after initialization*
:dict-init-mutate (W3301): *Dictionary mutated immediately after initialization*
Dictionaries can be initialized with a single statementusing dictionary
literal syntax.

Expand Down
8 changes: 6 additions & 2 deletions pylint/extensions/dict_init_mutate.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
class DictInitMutateChecker(BaseChecker):
name = "dict-init-mutate"
msgs = {
"W0170": (
"W3301": (
"Dictionary mutated immediately after initialization",
"dict-init-mutate",
"Dictionaries can be initialized with a single statement"
Expand All @@ -33,7 +33,11 @@ def visit_assign(self, node: nodes.Assign) -> None:
return

next_sibling = node.next_sibling()
if not next_sibling or not isinstance(next_sibling, nodes.Assign) or len(next_sibling.targets) != 1:
if (
not next_sibling
or not isinstance(next_sibling, nodes.Assign)
or len(next_sibling.targets) != 1
):
return

sibling_target = next_sibling.targets[0]
Expand Down
3 changes: 2 additions & 1 deletion tests/functional/ext/dict_init_mutate.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# pylint: disable=use-dict-literal
"""Example cases for dict-init-mutate"""
# pylint: disable=use-dict-literal, invalid-name

base = {}

Expand Down
2 changes: 2 additions & 0 deletions tests/functional/ext/dict_init_mutate.rc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[MAIN]
load-plugins=pylint.extensions.dict_init_mutate,
4 changes: 2 additions & 2 deletions tests/functional/ext/dict_init_mutate.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dict-init-mutate:13:0:13:11::Dictionary mutated immediately after initialization:HIGH
dict-init-mutate:21:0:21:11::Dictionary mutated immediately after initialization:HIGH
dict-init-mutate:14:0:14:11::Dictionary mutated immediately after initialization:HIGH
dict-init-mutate:22:0:22:11::Dictionary mutated immediately after initialization:HIGH

0 comments on commit 6bd578f

Please sign in to comment.