Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an faq detailing which messages to disable to avoid duplicates w/ other popular linters #3647

Merged
merged 7 commits into from
May 27, 2020

Conversation

danrneal
Copy link
Contributor

Description

Add an FAQ detailing which messages to disable to avoid duplicates when using other popular linters alongside pylint. Includes pycodestyle, pyflakes, mccabe, pep8-naming, and flake8-import-order.

Type of Changes

Type
📜 Docs

Related Issue

Related: #3512, #3517
This does not resolve them in any way. It only adds instructions in the faq on how to configure pylint manually while using other linters

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 90.679% when pulling bf48ea2 on danrneal:patch-1 into 1fc490c on PyCQA:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 90.679% when pulling bf48ea2 on danrneal:patch-1 into 1fc490c on PyCQA:master.

@coveralls
Copy link

coveralls commented May 27, 2020

Coverage Status

Coverage remained the same at 90.687% when pulling ef8f447 on danrneal:patch-1 into 1fc490c on PyCQA:master.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work, this is useful. I think maybe mccabes and too many branches are not exactly the same ? I also think it would makes default configuration or automatic disabling discussed in #3512 a lot easier to implements.

@danrneal
Copy link
Contributor Author

You would be correct that mccabe and too-many-branches are not exactly the same but they are fairly close. The too-many-branches just puts an upper bound on the branches which is simpler than what mccabe does which is measure the cyclomatic complexity (which main factor is number of branches but then assigns it a score). So while not exactly the same, mccabe is essentially a more complex version. I would think if you had mccabe enabled, too-many-branches is not going to give you any extra intelligent information.

mixed-indentation, bad-whitespace, and bad-continuation have been removed in the upcoming release of pylint
@Pierre-Sassoulas
Copy link
Member

Fair enough :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants