Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylint errors 1 #5957

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Pylint errors 1 #5957

merged 3 commits into from
Mar 24, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS.txt if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 📜 Docs

Description

Code examples based on pylint-errors and my own work.

Ref. #5953.

@DanielNoord DanielNoord reopened this Mar 24, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2034423903

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.104%
Totals Coverage Status
Change from base Build 2034330110: 0.0%
Covered Lines: 15210
Relevant Lines: 16163
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas requested changes Mar 24, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some propositions. Btw in class AnotherParentClass(AnotherClass): I think the child class is actually AnotherParentClass and the mother class is AnotherClass.

doc/data/messages/a/abstract-class-instantiated/bad.py Outdated Show resolved Hide resolved
doc/data/messages/a/abstract-class-instantiated/good.py Outdated Show resolved Hide resolved
doc/data/messages/a/abstract-method/bad.py Outdated Show resolved Hide resolved
doc/data/messages/a/abstract-method/good.py Outdated Show resolved Hide resolved
@DanielNoord @Pierre-Sassoulas
Apply suggestions from code review
c45ec30 
Co-authored-by: Pierre Sassoulas <[email protected]>
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Mar 24, 2022
@DanielNoord
Copy link
Collaborator Author

Some propositions. Btw in class AnotherParentClass(AnotherClass): I think the child class is actually AnotherParentClass and the mother class is AnotherClass.

👍 For these examples :)

@DanielNoord
Copy link
Collaborator Author

Something weird going on with the CI for this PR. Second time it doesn't fire..

@DanielNoord DanielNoord reopened this Mar 24, 2022
@DanielNoord DanielNoord reopened this Mar 24, 2022
@DanielNoord DanielNoord merged commit a5a5701 into pylint-dev:main Mar 24, 2022
@DanielNoord DanielNoord deleted the pylint-errors-1 branch March 24, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Documentation 📗
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas