Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation and code examples for consider-using-with #6009

Merged

Conversation

DudeNr33
Copy link
Collaborator

  • Write a good description on what the PR does.
  • If you used multiple emails or multiple names when contributing, add your mails
    and preferred name in script/.contributors_aliases.json

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Description

Good and bad examples for consider-using-with.
I decided to stick with the most obvious example.
The original PR and list of stdlib callables that are checked is based on this blog post.
Should we include that in related.rst, or should we stick to the official documentation only?

Ref: #5953

@coveralls
Copy link

coveralls commented Mar 28, 2022

Pull Request Test Coverage Report for Build 2050609103

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.154%

Totals Coverage Status
Change from base Build 2047793050: 0.0%
Covered Lines: 15334
Relevant Lines: 16286

💛 - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the article you used would be great in the related links.

@DudeNr33
Copy link
Collaborator Author

Thanks for the feedback, added it.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.14.0 milestone Mar 28, 2022
@DanielNoord DanielNoord merged commit de1cca2 into pylint-dev:main Mar 28, 2022
@DudeNr33 DudeNr33 deleted the consider-using-with-documentation branch March 28, 2022 08:26
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants