Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for undefined-all-variable message documentation #6160

Merged
merged 5 commits into from
Apr 3, 2022
Merged

Add example for undefined-all-variable message documentation #6160

merged 5 commits into from
Apr 3, 2022

Conversation

gunungpw
Copy link
Contributor

@gunungpw gunungpw commented Apr 3, 2022

  • Write a good description on what the PR does.

Type of Changes

Type
βœ“ πŸ“œ Docs

Description

  • add example for undefined-all-variable
  • add link for Python docs about import * Package (usage of __all__)

Related: #5953

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep only one import in __all__.

doc/data/messages/u/undefined-all-variable/bad.py Outdated Show resolved Hide resolved
doc/data/messages/u/undefined-all-variable/good.py Outdated Show resolved Hide resolved
@gunungpw
Copy link
Contributor Author

gunungpw commented Apr 3, 2022

Yep, agree πŸ‘

@Pierre-Sassoulas Pierre-Sassoulas merged commit 22f4d52 into pylint-dev:main Apr 3, 2022
@gunungpw gunungpw deleted the undefined-all-variable branch April 3, 2022 15:40
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants