Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation examples for fixme #7019

Closed
wants to merge 4 commits into from
Closed

Conversation

julthep
Copy link
Contributor

@julthep julthep commented Jun 24, 2022

Co-authored-by: Vladyslav Krylasov [email protected]

Type of Changes

Type
βœ“ πŸ“œ Docs

Description

Add documentation examples for fixme

Refs #5953

Co-authored-by: Vladyslav Krylasov <[email protected]>
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the check is that dumb πŸ˜„

doc/data/messages/f/fixme/good.py Outdated Show resolved Hide resolved
doc/data/messages/f/fixme/details.rst Show resolved Hide resolved
doc/data/messages/f/fixme/bad.py Outdated Show resolved Hide resolved
@Pierre-Sassoulas
Copy link
Member

I added work in progress because it seems there's an issue with the disable of fixme.

disable-next:

# pylint: disable-next=fixme
# TODO: We really need to fix this bug!
************* Module a
a.py:2:0: I0011: Locally disabling fixme (W0511) (locally-disabled)
a.py:2:1: W0511: TODO: We really need to fix this bug! (fixme)
a.py:2:0: I0021: Useless suppression of 'fixme' (useless-suppression)

Disabling does not work yet we get an useless suppression.

disable:


# TODO: We really need to fix this bug! # pylint: disable=fixme
************* Module a
a.py:2:0: I0011: Locally disabling fixme (W0511) (locally-disabled)
a.py:2:0: I0021: Useless suppression of 'fixme' (useless-suppression)

Disabling does work but we get an useless suppression.

@DanielNoord
Copy link
Collaborator

Issues fixed in #7144 which supersedes this PR. Thanks for the initial work @julthep!

@DanielNoord DanielNoord closed this Jul 7, 2022
@julthep julthep deleted the fixme branch July 7, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants