fix undefined-loop-variable with break and continue statements in else blocks
#7318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2888183236
💛 - Coveralls |
Pierre-Sassoulas
added
the
False Positive 🦟
Pierre-Sassoulas
previously approved these changes
Aug 18, 2022
| @@ -0,0 +1 @@ | |||
| fix `undefined-loop-variable` with `break` and `continue` statements in `else` blocks | |||
There was a problem hiding this comment.
Suggested change
| fix `undefined-loop-variable` with `break` and `continue` statements in `else` blocks | |
| Fix `undefined-loop-variable` with `break` and `continue` statements in `else` blocks | |
| Refs #7311 |
There was a problem hiding this comment.
i applied this change but the newsfragments check is still failing, no idea why
There was a problem hiding this comment.
I had to investigate for a humiliatingly long time, it seems the . is required. Regexes are hard 😄
Pierre-Sassoulas
previously approved these changes
Aug 18, 2022
This comment has been minimized.
This comment has been minimized.
DetachHead
force-pushed
the
main
branch
3 times, most recently
from
f67abbe
to
c0ada39
Compare
…in `else` blocks
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
approved these changes
Aug 19, 2022
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 48857eb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Refs #7311 (idk how to fix functions that return
NoReturn)