Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch UserWarning when linting stdlib #7833

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Catch UserWarning when linting stdlib #7833

merged 1 commit into from
Nov 23, 2022

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix

Description

Fixes #7832

Follow-up to #7809.

@jacobtylerwalls jacobtylerwalls added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Nov 23, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3533244297

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.425%
Totals Coverage Status
Change from base Build 3532165645: 0.0%
Covered Lines: 17521
Relevant Lines: 18361
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the speedy PR 👌

@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) November 23, 2022 15:19
@Pierre-Sassoulas
Copy link
Member

I disabled the automerge because I think automerge is what got us here in the first place. Let's merge once everything is green.

@github-actions
Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on django:
The following messages are no longer emitted:

  1. redefined-variable-type:
    Redefinition of value type from django.db.models.expressions.Value to django.db.models.expressions.BaseExpression
    https://github.com/django/django/blob/9582f2f9d173935fef35c8c27b0f80258b1fb106/django/db/models/lookups.py#L60

Effect on music21:
The following messages are now emitted:

  1. redefined-variable-type:
    Redefinition of theRest type from music21.note.Rest to list
    https://github.com/cuthbertLab/music21/blob/b274aa58d44b89484273071703d17dc2450016eb/music21/mei/base.py#L2310
  2. redefined-variable-type:
    Redefinition of theSpace type from music21.note.Rest to list
    https://github.com/cuthbertLab/music21/blob/b274aa58d44b89484273071703d17dc2450016eb/music21/mei/base.py#L2358

Effect on pandas:
The following messages are now emitted:

  1. redefined-variable-type:
    Redefinition of result type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.multi.MultiIndex
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/indexes/multi/test_reshape.py#L126
  2. no-member:
    Instance of 'PeriodIndex' has no 'tz' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/indexes/datetimes/methods/test_shift.py#L101
  3. redefined-variable-type:
    Redefinition of expected type from tuple to pandas.core.series.Series
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/series/methods/test_astype.py#L499
  4. invalid-unary-operand-type:
    bad operand type for unary ~: IntervalArray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_ops.py#L9
  5. redefined-variable-type:
    Redefinition of expected type from pandas.core.series.Series to pandas.core.frame.DataFrame
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_ops.py#L17
  6. redefined-variable-type:
    Redefinition of expected type from pandas.core.series.Series to pandas.core.arrays.period.PeriodArray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_function.py#L28
  7. redefined-variable-type:
    Redefinition of other type from .ndarray to pandas.core.series.Series
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_comparison.py#L34
  8. invalid-unary-operand-type:
    bad operand type for unary -: IntervalArray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/floating/test_arithmetic.py#L213
  9. invalid-unary-operand-type:
    bad operand type for unary +: IntervalArray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/floating/test_arithmetic.py#L213
  10. invalid-unary-operand-type:
    bad operand type for unary -: IntervalArray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/integer/test_arithmetic.py#L324
  11. invalid-unary-operand-type:
    bad operand type for unary +: IntervalArray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/integer/test_arithmetic.py#L324
  12. redefined-variable-type:
    Redefinition of indexer type from pandas.core.indexes.numeric.Int64Index to pandas.core.indexes.datetimes.DatetimeIndex
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/algorithms.py#L1360
  13. redefined-variable-type:
    Redefinition of data type from pandas.core.internals.array_manager.SingleArrayManager to pandas.core.internals.managers.BlockManager
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/series.py#L377
  14. unsupported-assignment-operation:
    'mangled_aggspec' does not support item assignment
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/apply.py#L1448
  15. redefined-variable-type:
    Redefinition of mangled_aggspec type from str to list
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/apply.py#L1450
  16. redefined-variable-type:
    Redefinition of indexer type from slice to list
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/frame.py#L3816
  17. no-member:
    Instance of 'RangeIndex' has no 'levels' member; maybe 'nlevels'?
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/indexes/base.py#L2040
  18. no-member:
    Instance of 'RangeIndex' has no 'codes' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/indexes/base.py#L2041
  19. redefined-variable-type:
    Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.indexes.base.Index
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/_testing/__init__.py#L277

The following messages are no longer emitted:

  1. redefined-variable-type:
    Redefinition of expected type from pandas.core.arrays.numpy_.PandasArray to pandas.core.indexes.base.Index
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/_testing/__init__.py#L277
  2. redefined-variable-type:
    Redefinition of indexer type from list to .ndarray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/frame.py#L3820
  3. redefined-variable-type:
    Redefinition of data type from pandas.core.internals.array_manager.SingleArrayManager to pandas.core.internals.managers.SingleBlockManager
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/series.py#L377
  4. redefined-variable-type:
    Redefinition of index type from pandas.core.indexes.base.Index to pandas.core.indexes.range.RangeIndex
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/series.py#L449
  5. redefined-variable-type:
    Redefinition of other type from pandas.core.arrays.period.PeriodArray to pandas.core.arrays.interval.IntervalArray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/arrays/interval.py#L739
  6. no-member:
    Instance of 'Index' has no 'levels' member; maybe 'nlevels'?
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/indexes/base.py#L2040
  7. no-member:
    Instance of 'Index' has no 'codes' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/core/indexes/base.py#L2041
  8. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L547
  9. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L548
  10. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L549
  11. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L556
  12. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L557
  13. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L558
  14. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L559
  15. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L561
  16. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L562
  17. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L564
  18. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L566
  19. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L603
  20. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L604
  21. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L605
  22. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L606
  23. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L607
  24. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L616
  25. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L617
  26. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L618
  27. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L619
  28. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L620
  29. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L621
  30. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L622
  31. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L623
  32. no-member:
    Instance of 'SingleBlockManager' has no 'iget' member
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/internals/test_internals.py#L624
  33. redefined-variable-type:
    Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.arrays.floating.FloatingArray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/integer/test_arithmetic.py#L117
  34. redefined-variable-type:
    Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.series.Series
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/integer/test_function.py#L20
  35. redefined-variable-type:
    Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.arrays.floating.FloatingArray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/floating/test_arithmetic.py#L68
  36. redefined-variable-type:
    Redefinition of res type from pandas.core.arrays.period.PeriodArray to pandas.core.arrays.floating.FloatingArray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/floating/test_construction.py#L142
  37. redefined-variable-type:
    Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.series.Series
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/floating/test_function.py#L21
  38. redefined-variable-type:
    Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.series.Series
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/floating/test_function.py#L36
  39. redefined-variable-type:
    Redefinition of other type from pandas.core.arrays.period.PeriodArray to .ndarray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_comparison.py#L32
  40. redefined-variable-type:
    Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.series.Series
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_ops.py#L11
  41. redefined-variable-type:
    Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.series.Series
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_function.py#L21
  42. redefined-variable-type:
    Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.series.Series
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_function.py#L64
  43. redefined-variable-type:
    Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.series.Series
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/boolean/test_function.py#L125
  44. redefined-variable-type:
    Redefinition of expected type from .ndarray to pandas.core.arrays.period.PeriodArray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/string_/test_string.py#L211
  45. redefined-variable-type:
    Redefinition of expected type from .ndarray to pandas.core.arrays.period.PeriodArray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arrays/string_/test_string.py#L252
  46. redefined-variable-type:
    Redefinition of expected type from list to pandas.core.arrays.period.PeriodArray
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/arithmetic/test_datetime64.py#L239
  47. redefined-variable-type:
    Redefinition of result type from pandas.core.indexes.numeric.Int64Index to pandas.core.indexes.multi.MultiIndex
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/indexes/multi/test_reshape.py#L126
  48. redefined-variable-type:
    Redefinition of dti type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.numeric.Int64Index
    https://github.com/pandas-dev/pandas/blob/d1ecf63e2040daecad6e0a8485a35e8a23393795/pandas/tests/indexes/datetimes/test_misc.py#L254

This comment was generated for commit 5282dcc

@jacobtylerwalls jacobtylerwalls merged commit ed404d3 into pylint-dev:main Nov 23, 2022
@jacobtylerwalls jacobtylerwalls deleted the catch-warnings-stdlib branch November 23, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI crashes on stdlib primer
3 participants
@jacobtylerwalls @coveralls @Pierre-Sassoulas