multiple-statements no longer triggers for function stubs using inlined ...
#7863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tubs using `...`
for more information, see https://pre-commit.ci
mbyrnepr2
reviewed
Nov 29, 2022
Co-authored-by: Mark Byrne <[email protected]>
mbyrnepr2
reviewed
Nov 29, 2022
Co-authored-by: Mark Byrne <[email protected]>
Pull Request Test Coverage Report for Build 3572984252
💛 - Coveralls |
mbyrnepr2
reviewed
Nov 29, 2022
Co-authored-by: Mark Byrne <[email protected]>
Pierre-Sassoulas
added
the
False Positive 🦟
This comment has been minimized.
This comment has been minimized.
mbyrnepr2
previously approved these changes
Nov 29, 2022
There was a problem hiding this comment.
I like it @GideonBear thank you!
Lets see what the CI thinks about it.
Co-authored-by: Pierre Sassoulas <[email protected]>
GideonBear
dismissed stale reviews from mbyrnepr2 and Pierre-Sassoulas
via
16fe7bd
|
What does "dismissed stale reviews" mean? I might've accidentally applied the suggestion twice. |
I think its just when you add a commit after a review was made by one of the reviewers; happens all the time. |
Pierre-Sassoulas
approved these changes
Nov 29, 2022
mbyrnepr2
approved these changes
Nov 29, 2022
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 16fe7bd |
Pierre-Sassoulas
changed the title
multiple-statements (C0321) now no longer triggers for function stubs using ...multiple-statements no longer triggers for function stubs using inlined ...
|
🎉 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
…nlined ``...`` (#7863) Co-authored-by: Mark Byrne <[email protected]> Co-authored-by: Pierre Sassoulas <[email protected]> (cherry picked from commit 6b427a9)
|
@Pierre-Sassoulas say the line :D |
|
Haha, ok, but you did all the reviewing work @mbyrnepr2 :) Congratulation on becoming a pylint contributor @GideonBear 😉 |
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Dec 4, 2022
…nlined ``...`` (#7863) Co-authored-by: Mark Byrne <[email protected]> Co-authored-by: Pierre Sassoulas <[email protected]> (cherry picked from commit 6b427a9)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Dec 4, 2022
…nlined ``...`` (#7863) Co-authored-by: Mark Byrne <[email protected]> Co-authored-by: Pierre Sassoulas <[email protected]> (cherry picked from commit 6b427a9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple-statements(C0321) now no longer triggers for function stubs using...Type of Changes
Description
Closes #7860