Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport maintenance/2.15.x] Fix used-before-assignment false positive for walrus operators in ifs #8033

Merged
merged 1 commit into from
Jan 8, 2023
Merged

[Backport maintenance/2.15.x] Fix used-before-assignment false positive for walrus operators in ifs #8033

merged 1 commit into from
Jan 8, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 8, 2023

Backport 6ac908f from #8029.

@zenlyj @github-actions
Fix used-before-assignment false positive for walrus operators in i…
e90baf1 
…fs (#8029)

Co-authored-by: Pierre Sassoulas <[email protected]>
(cherry picked from commit 6ac908f)
@Pierre-Sassoulas Pierre-Sassoulas changed the title [Backport maintenance/2.15.x] Fix used-before-assignment false positive [Backport maintenance/2.15.x] Fix used-before-assignment false positive for walrus operators in ifs Jan 8, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.10 milestone Jan 8, 2023
@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Jan 8, 2023
@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (maintenance/2.15.x@1673aa6). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 6ac908f differs from pull request most recent head e90baf1. Consider uploading reports for the commit e90baf1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##             maintenance/2.15.x    #8033   +/-   ##
=====================================================
  Coverage                      ?   95.42%           
=====================================================
  Files                         ?      176           
  Lines                         ?    18527           
  Branches                      ?        0           
=====================================================
  Hits                          ?    17680           
  Misses                        ?      847           
  Partials                      ?        0

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3867358988

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0005%) to 95.179%
Totals Coverage Status
Change from base Build 3822525352: 0.0005%
Covered Lines: 17116
Relevant Lines: 17983
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas merged commit 0741949 into maintenance/2.15.x Jan 8, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-8029-to-maintenance/2.15.x branch January 8, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.15.10
Development

Successfully merging this pull request may close these issues.
3 participants
@coveralls @Pierre-Sassoulas @zenlyj