Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __init__.py files to message test dirs #8772

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #8762

Other doc checks that have multiple files under good/ or bad/ have an __init__.py file. The specific way tox was launching the tests was causing astroid to expect an __init__.py file, and these two didn't have them.

@jacobtylerwalls jacobtylerwalls added tests Skip news πŸ”‡ This change does not require a changelog entry labels Jun 13, 2023
@jacobtylerwalls jacobtylerwalls changed the title Add __init__ files to message test dirs Add __init__.py files to message test dirs Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #8772 (514ede6) into main (7eaac57) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8772   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files         173      173           
  Lines       18437    18437           
=======================================
  Hits        17669    17669           
  Misses        768      768           

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I was working in it with less success πŸ˜„

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip news πŸ”‡ This change does not require a changelog entry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failure on main: documentation check
2 participants